Repository navigation
fix: multi-database stress regressions, settings feedback, and grid alignment - #188
Merged
Merged
Conversation
- Add SettingsFeedback (idle/pending/success/error with optional progress and status/alert roles) and use it across the settings sections. - Providers: upsert by id, surface sync errors instead of failing silently, and persist synced models. - JRE/drivers, MCP bridge, plan, and AI settings: consistent feedback states, retry affordances, and layout cleanup. - Updater and download events: reset and surface errors, guard install after the update check. - DDL modal header reserves room for the close button. - i18n strings for the new feedback states (en/zh).
Header justification now derives from the column type through the same helper the cells use, so numeric and boolean headers match their data instead of sitting at the opposite edge of the column. Sort and filter indicators stay after the column name and are pulled into the cell padding, which keeps the label flush with the values instead of stopping a sort-arrow's width short. Sort-priority numbers are shown only for multi-column sorts, since a lone "1" added width without conveying anything.
Easy-to-hard queries against the four live stress-test databases, including dialect variants (row limit, month bucketing, recursion, JSON), an idempotent upsert per engine, and EXPLAIN examples. Useful for exercising the editor and result grid manually.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Complex SQL fixtures exposed crashes, lost session state, missing result sets, and incorrect metadata across PostgreSQL, MySQL, SQL Server, and Oracle. This fixes those adapter paths and makes
docs/sql-testreproducible through the real Rust adapters and Java JDBC bridge. The same branch now also carries the settings-feedback pass and the result-grid fixes found while validating the fixtures in the desktop app.Changes
Database adapters
DBMS_METADATA.Settings
SettingsFeedbackcomponent (pending/success/error with optional progress,status/alertroles) and use it across the settings sections.Result grid
Docs
docs/sql-test/sample-queries.md: graduated easy-to-hard query ladder with per-engine dialect variants, an idempotent upsert per engine, and EXPLAIN examples.Validation
cargo test --manifest-path src-tauri/Cargo.toml: 547 tests passed; database-dependent tests remain ignored by default.npm test: 686 tests passed.npm run build: passed.npm run lint:check: zero errors; one pre-existing UnoCSS ordering warning inDefaultAvatar.vue.git diff --check: passed.Desktop visual interactions and complete DDL round trips are outside this automated coverage. The live runner recreates the documented disposable fixtures; Oracle's separate JDBC requests retain their existing autocommit behavior.