Repository navigation
Conversation
…ents In multi-tenant BTP deployments, OAuth metadata and token exchanges were resolved against provider-level XSUAA endpoints, causing tokens to be issued for the wrong tenant. This change derives the subscriber-specific XSUAA URLs from the request host so that OAuth flows run in the correct tenant context.
Resolved conflict in src/auth/utils.ts by accepting main branch version that keeps the OAuth protected resource endpoint disabled as a hotfix. The endpoint causes authentication failures because MCP clients don't send application/json in Accept headers, causing XSUAA to return HTML. This follows the KISS principle: keep the safe, documented hotfix until proper investigation and testing can be completed. Co-authored-by: Cursor <cursoragent@cursor.com>
- Replace generic SecurityContext<any, any> with XsuaaSecurityContext - Remove hardcoded uaadomain fallback, now throws error if missing
Collaborator
Author
|
@geert-janklaps if you have some time, can you check if this PR resolves the issues you reported on #125? 😄 |
Contributor
|
Thanks for looking into the issues and helping move this forward. I’ve been quite busy recently, so I really appreciate you taking over the PR. For context, I tested this in our environment with multi-tenancy on Cloud Foundry only. I haven’t tested it on Kyma yet |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Based on PR #125 by @agustino-lim
In addition to the multi-tenant related changes provided in the aforementioned PR, a subdomain clean process has been added that verifies the subdomain url against app domain knowledge retrieved from VCAP_APPLICATION information in the CloudFoundry runtime.
This fix will NOT work for Kyma runtimes to my knowledge.
Type of Change
Related Issues
What Changed
Testing
Impact
Review Focus
Additional Context