Repository navigation
[pull] main from bazel-contrib:main - #751
Merged
Merged
Conversation
When a release or backport workflow triggered by an issue or PR comment fails, no notification appears on the thread. Maintainers must manually check the Actions tab to discover that a command failed. Add a failure-reporting job to the comment workflow that runs whenever any upstream job fails. It adds a thumbs-down reaction to the triggering comment and posts a reply linking to the failed workflow run.
Bazel reports source symlinks as regular files, causing Python executable aliases to be copied into zipapps as full binaries. Hermetic runtimes also include shared libpython artifacts even when the interpreter links Python statically. Preserve source symlinks through sandbox indirection and exclude libpython shared objects from runtime files while retaining them for explicit native dependencies. Add regression coverage for archive structure and native extension loading. Fixes #3534 Fixes #4163 --------- Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Co-authored-by: Richard Levasseur <richardlev@gmail.com>
…4184) On Windows ARM64, evaluating the `pip` extension fails as soon as any module in the graph calls `pip.parse` for Python 3.9 or 3.10: ``` Unable to find interpreter for pip hub 'grpc_python_dependencies' for python_version=3.9: ... Expected to find python_3_9_host among registered versions: python_3_11_host python_3_12_host python_3_13_host ``` There is no CPython 3.9 or 3.10 build for `aarch64-pc-windows-msvc` in the runtime manifest, so those toolchains have no host interpreter there. `_pip_parse` already handles a close relative of this: a version missing from `minor_mapping` is skipped with an info message, and the hub's select fails later only if that version is actually used. This treats a version with no host interpreter the same way, right after that check. The `python_X_Y_host` name is built in one small helper, so the new check and `_detect_interpreter` look at the same thing. To check it, I ran `bazel query @bazel_pip_dev_deps//:all` in a plain checkout of Bazel master (rules_python 1.9.2, grpc 1.76.0) with and without this change back-ported to 1.9.2, on `windows-11-arm` and `ubuntu-latest`: ``` without with windows-arm64 rc=7 rc=0 3.9 and 3.10 skipped for grpc, protoc-gen-validate and rules_fuzzing linux-x86_64 rc=0 rc=0 nothing new skipped ``` https://github.com/zakinko/NetBSD-i386/actions/runs/36248007899 With `RULES_PYTHON_REPO_DEBUG_VERBOSITY=INFO` the Windows run prints the new message once for each of the six hub and version pairs, next to the existing "no registered toolchain" one for rules_fuzzing's 3.8. The new test in `hub_builder_tests.bzl` fails without the change with the same error, and `//tests/pypi/...` passes with it (254 tests, on macOS). --------- Co-authored-by: Richard Levasseur <richardlev@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )