Repository navigation
Add skipWhile, skipWhileInclusive with async variants, and takeUntil etc #130
Description
Similar to #122. The naming should be skipWhile, even though skipUntil was proposed as well in that thread. F# Core has skipWhile, so we should stick with that. Also, I think they are semantically different:
Skip while
skipWhile: as long as predicate is true, keep skipping, then stopskipWhileAsync: same, but asyncskipWhileInclusive: same, but yield first, then test predicate on yielded valueskipWhileInclusiveAsync: same, but async
Skip until
skipUntil: skip until predicate becomes trueskipUntilAsync: same, but asyncskipUntilInclusive: same, but skip first, then test predicateskipUntilInclusiveAsync:same, but asyncate
And the missing Take Until
We should include these if we do the skipUntilXXX functions:
takeUntil: as long as predicate is false, keep skipping, then stoptakeUntilAsync: same, but asynctakeUntilInclusive: same, but yield first, then test predicate on yielded valuetakeUntilInclusiveAsync: same, but async
Not sure we should have both until and while, as they are logically each other's opposites.
Reacted by Ruben Bartelink
Activity
[-]Add `skipWhile`, `skipWhileInclusive` with async variants[/-][+]Add `skipWhile`, `skipWhileInclusive` with async variants, and `takeUntil` etc[/+]abelbraaksma commentedon Oct 30, 2023
Updated the body of the request to include the
asyncvariants and thetakeUntilvariants as well to complete the block.abelbraaksma commentedon Dec 21, 2023
Note on #183: we (@bartelink and I, well, he convinced me) decided to skip the
untilvariants of these functions, as they were nothing more than the logical inverse (i.e., users can use thenotfunction to reach that functionality).Further work is through #208 and #219.