Repository navigation
games_services_watchos 0.2.1: upstream's example - #28
Merged
Merged
Conversation
The example was a hand-written watch demo with a layout widget test. AUTHORING.md §3 asks for upstream's own example, unchanged, so it is now games_services' example app, ported with `flutter-watchos plugin port --include-example` (#24). The porter copies lib/ only, so the example's assets/logo.png and the assets entry of its pubspec come from games_services 5.3.0 by hand. The example is MIT-licensed upstream code, so example/LICENSE carries that licence, and the word allow-list lists its "free of charge" line, as it does for the MIT licences of audioplayers and geolocator. games_services has no integration test. Ours is renamed watchos_games_services_test.dart, so it is not taken for an upstream test. The layout test of the old demo goes with the demo. On the watchOS 27.0 Simulator the 7 tests pass, and the example starts with no exception in its first 15 seconds and no overflow.
Member
Author
|
Re-checked the example's start the way spec 0006 criterion 8a asks: built with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #24.
Example. Our example was a hand-written watch demo with a layout widget test. It is now
games_services' own example app, unchanged, ported withflutter-watchos plugin port --include-example. There are no watchOS deviations.lib/only, so the example'sassets/logo.pngand theassets:entry of its pubspec were copied from games_services 5.3.0 by hand.example/LICENSEcarries that licence. The word allow-list lists its "free of charge" line, as it already does for the MIT licences of audioplayers and geolocator.Tests. games_services has no integration test. Ours is renamed
watchos_games_services_test.dart, so it is not taken for an upstream test. The old demo's layout test goes with the demo.Verified on the watchOS 27.0 Simulator
watchos_games_services_test.dart: 7 pass.Unit tests (55) and
flutter analyze lib testare clean. The repo's version, example-constraint, README-snippet, test-name, word and format checks pass.pub publish --dry-runincludes the logo, with no other warning.Version 0.2.1 with a CHANGELOG entry. The README gains an Example section, and the PORTING_REPORT gets its verification rows and an Example section.