Repository navigation
Name empty Astro projects like Lumos sites - #55
Open
SylvainDruaux wants to merge 3 commits into
Open
SylvainDruaux wants to merge 3 commits into
SylvainDruaux wants to merge 3 commits into
Conversation
The "Empty Astro project…" wizard now asks for a site name, shows the folder it will create and only asks where the site should go. Both wizards share one name field and the main process checks the name the same way for both. If create-astro fails before writing anything, the empty folder is removed so "Try again" works.
The modal's label rule overrode the field's column layout, so the name sat directly on its input. The gap now matches the template question's spacing, in both the Lumos and empty Astro wizards.
The empty Astro project wizard now names its own folder, so nothing calls project:newDialog any more.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "Empty Astro project…" option asked for an empty folder that you had
to create yourself first. It now works like "Start from Lumos…": choose
where the site should go, then name it in the wizard.
my-site) with apreview of the folder that will be created.
<parent>/<name>and checks the name thesame way for both flows (
newSiteDirectory).removed, so "Try again" works.
wizards.
project:newDialogchannel.Merge note: this PR and the Wrangler / package manager PR both change
the handler count in
test/electron/app/mainBoundaries.test.ts. If theyare merged in either order, the second one conflicts there, and the
right value is 134.
Tested: the full gate passes, and both wizards were tested by hand on
macOS (create, invalid name, existing folder).