Repository navigation
Install Wrangler and project dependencies with the site's package manager - #54
Open
SylvainDruaux wants to merge 5 commits into
Open
SylvainDruaux wants to merge 5 commits into
SylvainDruaux wants to merge 5 commits into
Conversation
The account service and the sign-in dialog each kept their own list of pending states, so a new state could silently be treated as finished. Both now use accountSignInPending from the shared contract, a switch with a never check, so a new state fails to compile until classified.
A project can name its package manager in package.json's packageManager field (e.g. "pnpm@9.12.0"), which is more reliable than guessing from a lockfile. Detection now checks that field first, then the lockfile, then falls back to npm. An unknown or unreadable field falls back the same way.
Cloudflare sign-in installed a missing Wrangler always with npm, so sites using pnpm, Yarn or Bun ended up with a second lockfile, and cancelling could leave node_modules half installed. It now installs with the site's package manager, and cancelling skips sign-in but lets the install finish. The dialog stays on one screen from installation to browser sign-in or Try again, and says when the site's dependencies changed. A Wrangler removed while Stacki runs is detected as missing again instead of failing to start.
Opening and creating projects install dependencies in the main process, so nothing called project:hasNodeModules or project:install any more. Removing them with their preload methods and renderer bridges leaves the renderer one fewer way to start an install.
pnpm 11 and later exit with an error when they block a dependency's build script, such as Astro's esbuild, even though everything else is installed, so opening or creating a pnpm project failed. Installs now keep those scripts blocked without failing, as the Wrangler install does. The missing-manager error no longer claims a lockfile was found, since the manager can also come from package.json.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cloudflare sign-in installed a missing Wrangler with npm regardless of the
site, so pnpm, Yarn and Bun sites ended up with a second lockfile, and
cancelling could leave node_modules half installed. On pnpm 11 and later,
both the Wrangler install and the dependency install on project open also
failed, because pnpm exits with an error when it blocks a build script.
Commits:
dialog, so a new sign-in state fails to compile until classified.
then the lockfile, then npm.
but lets the install finish. The Cloudflare dialog stays on one screen from
installation to browser sign-in or Try again, and says when the site's
dependencies changed. A Wrangler removed while Stacki runs is detected as
missing again instead of failing to start.
since dependency installs moved to the main process.
(--config.strict-dep-builds=false), for both installs.
Tested: full gate (377/377) on top of 0.1.73, plus manual checks on macOS
with a pnpm site (Wrangler install, cancel, reinstall after removal, project
open without node_modules) and new Lumos and empty Astro projects.
Known limitation: on Windows, a native Bun install (bun.exe) is not found by
the tool lookup, so Bun sites get a clear "Could not run Bun" error instead
of installing Wrangler.