Repository navigation
fix(flow-php/etl): array_expand() no longer copies every input column per element - #2674
Merged
Merged
Conversation
… per element - expansions run on ExpandingProcessor, output in batches of at most 1,000 rows - optimizer prunes columns a later select()/drop() discards before expanding - ScalarFunctionTransformer refuses array_expand(), NestedExpandTransformer removed - native string columns use 64-bit offsets in flow-php-ext and arrow-ext - serialized Rows split into frames past the 2 GiB offset limit
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## 1.x #2674 +/- ##
============================================
+ Coverage 89.37% 89.39% +0.01%
- Complexity 0 27866 +27866
============================================
Files 2111 2117 +6
Lines 81983 82107 +124
============================================
+ Hits 73275 73400 +125
+ Misses 8708 8707 -1 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #xxx
Change Log
Added
flow-php/etl- optimizer rule pruning columns a later select()/drop() discards before an expansionFixed
flow-php/etl- array_expand() no longer copies every input column once per elementflow-php/flow-php-ext- a native string column past 2 GiB no longer overflows its offsetsChanged
flow-php/etl- an expanding withEntry() emits batches of at most 1,000 rowsflow-php/etl- ScalarFunctionTransformer refuses array_expand()flow-php/etl- a serialized Rows holds a list of framesflow-php/flow-php-ext- native strings use 64-bit offsets (LargeBinary)flow-php/arrow-ext- canonical string type is LargeBinaryRemoved
flow-php/etl- NestedExpandTransformerDeprecated
Security