Repository navigation
fix: partitioned reads keep their values and datetime filters work - #2672
Merged
Merged
Conversation
- datetime and float partition values written in full, read back exactly - parquet and floe type a partition column the file holds like the read - string operands cast to a datetime / date counterpart in comparisons - comparisons share a ComparisonFunction contract, between() checks types at bind - RoundTripPrecision moved to flow-php/types
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 1.x #2672 +/- ##
============================================
+ Coverage 89.36% 89.37% +0.01%
- Complexity 27763 27798 +35
============================================
Files 2110 2111 +1
Lines 81901 81983 +82
============================================
+ Hits 73188 73274 +86
+ Misses 8713 8709 -4 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #xxx
Change Log
Added
flow-php/etl-ComparisonFunctioncontract for comparison functionsFixed
flow-php/filesystem- datetime and float partition values keep their full value in the pathflow-php/etl-adapter-parquet- a partition column the file holds is typed from the file in pushed filtersflow-php/etl- Floe types a partition column the file holds from the file in pushed filtersChanged
flow-php/etl- a string compared with a datetime or date is cast to itflow-php/etl-between()refuses incomparable bounds at bindflow-php/types-RoundTripPrecisionmoved here fromflow-php/etlRemoved
Deprecated
Security