Repository navigation
fix: keyset pagination rejects NULL and duplicate keys at every batch size - #2671
Merged
Merged
Conversation
… size - NULL check query before the first page, in both keyset extractors - duplicate and collation-equal keys detected via a one-row page lookahead - a short page ends the read without an extra query - lib keyset rejects query LIMIT/OFFSET, a mismatched ORDER BY and NULL cursor values - same-direction composite keys use a row comparison - DBAL KeySet requires at least one key
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 1.x #2671 +/- ##
============================================
+ Coverage 89.31% 89.36% +0.04%
- Complexity 27705 27763 +58
============================================
Files 2105 2110 +5
Lines 81696 81901 +205
============================================
+ Hits 72963 73187 +224
+ Misses 8733 8714 -19 🚀 New features to boost your workflow:
|
- nix extension dev versions bumped to 0.46.0-dev - keyset upgrading entries moved to 0.45.x → 0.46.x
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #2670
Change Log
Added
flow-php/etl-adapter-postgresql- keyset reads run a NULL key check query before the first pageflow-php/etl-adapter-doctrine- keyset reads run a NULL key check query before the first pageFixed
flow-php/etl-adapter-postgresql- keyset reads no longer drop NULL or duplicate key rows depending on batch sizeflow-php/etl-adapter-doctrine- keyset reads no longer drop NULL or duplicate key rows depending on batch sizeflow-php/etl-adapter-postgresql- quoted keyset keys read their unquoted result columnsflow-php/postgresql- keyset pagination no longer silently replaces a query's own LIMITflow-php/postgresql- keyset pagination rejects a NULL cursor valueChanged
flow-php/etl-adapter-postgresql- a short keyset page ends the read without an extra queryflow-php/etl-adapter-doctrine- a short keyset page ends the read without an extra queryflow-php/etl-adapter-doctrine- keyset extractor rejects setMaxResults() / setFirstResult()flow-php/etl-adapter-doctrine- pagination_key_set() requires at least one keyflow-php/postgresql- keyset query ORDER BY must equal the keysflow-php/postgresql- same-direction composite keyset keys use a row comparisonRemoved
Deprecated
Security