Repository navigation
v0.6.64 - #317
Merged
Merged
v0.6.64#317
Conversation
The Vehicle and Fleet resources read the request's `with` list and hand it to `loadMissing()`. That is safe on their own endpoints, where the controller has already allowlisted the list, but both resources are also rendered nested inside Order and Driver responses. There the same request carries the parent's expansions (`payload`, `driverAssigned.vehicle`), so an order fetched with `?with=payload` that has a vehicle assigned failed during serialisation with RelationNotFoundException: "Call to undefined relationship [payload] on model Vehicle". `requestedRelations()` now keeps only entries whose root segment is a relation the wrapped model defines, and returns nothing for resources that wrap plain data. Direct endpoint behaviour is unchanged.
…relations fix: keep parent expansions away from nested Vehicle and Fleet resources
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #317 +/- ##
===========================================
Coverage 100.00% 100.00%
- Complexity 10003 10007 +4
===========================================
Files 531 531
Lines 38585 38592 +7
===========================================
+ Hits 38585 38592 +7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.