Repository navigation
fix: no default backup bucket; example bucket names in tests - #296
Merged
Merged
Conversation
DB_BACKUP_BUCKET now has no default, so an install writes to the bucket it configures rather than a hard-coded name.
roncodes
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release/v1.6.69 #296 +/- ##
===================================================
Coverage 100.00% 100.00%
Complexity 8269 8269
===================================================
Files 453 453
Lines 26441 26441
===================================================
Hits 26441 26441
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DB_BACKUP_BUCKETno longer has a hard-coded default, so an install writes to the bucket it configures. With no bucket set, the s3 disk's own bucket is used.