Repository navigation
feat: fit and constrain the camera on a pitched map - #2285
Open
greensopinion wants to merge 1 commit into
Open
greensopinion wants to merge 1 commit into
greensopinion wants to merge 1 commit into
Conversation
Camera fits now account for pitch. The contain constraints, which 04c3e14 broke on pitched maps, ignore pitch again, as in MapLibre GL JS, so they no longer refuse pitch changes. At pitch 0, fits and constraints behave as before.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Camera fits now account for pitch. The contain constraints, which
#2283 broke on pitched maps, ignore pitch again, as in MapLibre GL JS,
so they no longer refuse pitch changes. At pitch 0, fits and constraints
behave as before.
Depends on #2282.
I wrote this with Claude Code (Claude Opus 5.5). I directed the design,
reviewed the code, and tested it on a Mac, an iPhone 13, an iPhone 15 Pro
Max, a Pixel 4a (5G), and in Chrome.