Repository navigation
qemu_template: fix -S flag when '-- -snapshot' was provided - #4311
Merged
Merged
Conversation
This change fixes a corner case in #4310 when the new '-S' option introduced in that PR was not provided, but the classic '-- -snapshot' pass-through option is used. Since the PR explicitly sets 'snapshot=off' on all disks individually, and since per-disk options override global options, '-- -snapshot' is effectively ignored. Signed-off-by: Thilo Fromm <thilofromm@microsoft.com>
There was a problem hiding this comment.
🟢 Approval recommended
The conditional drive options correctly allow global -snapshot to take effect without regressing -S.
0 open findings
What changed in this PR
Restores QEMU’s forwarded -snapshot behavior while preserving wrapper-level -S support.
Changes:
- Omits per-drive snapshot settings by default.
- Appends
snapshot=onto writable drives when-Sis used.
| File | Description |
|---|---|
build_library/qemu_template.sh |
Makes per-drive snapshot configuration conditional. |
🧠 Review effort: Balanced
Give feedback about Copilot approvals in this survey to enter a drawing for a $150 gift card.
chewi
approved these changes
Oct 8, 2026
This branch is waiting to be deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change fixes a corner case in #4310 when the new
-Soption introduced in that PR was not provided, but the classic-- -snapshotpass-through option is used. Since the PR explicitly setssnapshot=offon all disks individually, and since per-disk options override global options,-- -snapshotis effectively ignored.This PR restores the previous behaviour while retaining the new
-Soption.