Repository navigation
Open
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates dependency version ranges in Package.swift and Package.resolved, adds Sendable conformances to authentication context types, removes redundant await keywords and argument labels, and adds .macOS(.v12) to the supported platforms in Package.swift. Feedback on the changes highlights that declaring macOS support in Package.swift will cause compilation failures because several targets use iOS-only APIs without conditional compilation guards.
morganchen12
approved these changes
Oct 9, 2026
paulb777
reviewed
Oct 9, 2026
paulb777
left a comment
paulb777
left a comment
Member
There was a problem hiding this comment.
Follow-Up Note (Post-Firebase 13 / GSI 10.1.0 Release)
- Once
firebase-ios-sdk13.0.0 andGoogleSignIn-iOS10.1.0 are tagged, consider bumping at least one sample/test Xcode project (samples/swift/FirebaseUI-demo-swift.xcodeprojis currentlyupToNextMajorVersionfrom12.14.0, ande2eTest/FirebaseSwiftUIExample.xcodeprojisupToNextMajorVersionfrom11.12.0) and/orPackage.resolvedso CI builds and tests against Firebase 13 directly.
paulb777
approved these changes
Oct 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After merging, this would need a SPM-only v16.2.0 tag and release page creation.
🎯 Usefulness is blocked until GSI 10.1.0 that will include Firebase 13 compatibility: google/GoogleSignIn-iOS#626
CocoaPods should no longer be published in alignment with firebase-ios-sdk.