Repository navigation
Guard [[unlikely]] attribute use with C++20 language check - #428
Closed
officialjisanhalder-art wants to merge 1 commit into
Closed
officialjisanhalder-art wants to merge 1 commit into
officialjisanhalder-art wants to merge 1 commit into
Conversation
…tfloat#427) Clang recognizes `__has_cpp_attribute(unlikely)` even when compiling in C++17 mode (`-std=c++17`), but using `[[unlikely]]` before C++20 emits `-Wc++20-attribute-extensions` under `-pedantic`. Require C++20 or later (`__cplusplus >= 202002L` or `_MSVC_LANG >= 202002L`) before enabling `FASTFLOAT_USE_UNLIKELY_ATTR`. Pre-C++20 builds on GCC and Clang will continue to use `__builtin_expect(!!(x), 0)` without extension warnings. Fixes fastfloat#427 Co-authored-by: ByteAsk <support@byteask.ai>
Contributor
|
Gotta love how clang manages to make the |
Member
|
@jwakely Hmmm.... Does it ? I am not going to merge this. If clang triggers The issue should be reported with LLVM. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Redundant semicolons at namespace scope in include/fast_float/fast_float.h triggered -Wextra-semi warnings under strict compiler configurations.
Changes
Testing
Fixes #427