Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Equalpanics for valid JSON such as[null]because array comparison passes nil child nodes tolazyNode.equal, which immediately dereferences the receiver.Check both pointers before inspecting the node kind in the root/v4 and v5 implementations. Two null elements compare equal; a null and non-null element compare unequal. Other comparison behavior is unchanged.
Add regression tests for null elements in both directions, later array positions, nested arrays, reordered object keys, and differences following a null element. The regression fails with a nil pointer panic before the fix.
Fixes #226
Validation (Go 1.23.12, darwin/arm64):
GO111MODULE=off go test -vet=off(root/v4). Vet is disabled because the existingmerge_test.gouses a non-constantFatalfformat string rejected by this toolchain's vet.GOWORK=off go -C v5 test ./...(v5).