Repository navigation
Replace the two HTML reports with one offline report page - #109
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cloudexit now writes one HTML report.
index.htmlis rebuilt to the new design: header with a Help tour, title bar with the provider logo and a Download menu, a section menu, and Overview, Scores (without values), Risks, Resource Inventory, Alternative Technologies, Egress & Data Landscape (when egress ran) and About This Report, ending in the disclaimer and the legal notices. It works without network access.egress.htmlis gone.Changes
Report page
report.css; fonts from the shipped Plex TTFs; plain JavaScript; no CDN, no external requests.html_sections,html_egress), so it says what the PDFs say. States: without egress, Terraform state, empty scope, uploaded with and without a link.Egress
generate_reportand used by the page and the egress PDF;egress.htmland its CLI step are removed. The CLI prints the egress PDF path;egress_failedand exit code 9 are unchanged.Assets
js/,css/driver.css,css/report.css,img/csp/*.svg, and a notice that the logo files are not under the AGPL.copy_assetsalso copies fonts and js. Removedstyle.cssand the egress template.Wording
Tests and tools
Differences from the design page
Compatibility
egress.htmlis no longer written;index.htmlis redesigned, works offline and contains the egress section. The PDFs change only in the trademark sentence and the Enterprise Support label.