Repository navigation
Stop writing credential identifiers into the egress PDF and run.log - #104
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The egress PDF's "Scope of Assessment" table printed the AWS Access Key ID in full and a masked Secret Key, or the Azure Client ID and a masked Client Secret, and
run.logreceived the Azure client ID from MSAL's debug output. Both are files users share. The scope table now shows the same scope facts as page 2 of the Executive Summary, and nothing else, and MSAL no longer writes to the log.Changes
Egress PDF
scope_facts, formerly private), with the same labels.anonymize_stringis removed; nothing else used it.Logging
msalis pinned to WARNING at every verbosity, because its debug output includes the client ID;urllib3connection lines appear only at-vv.Tests
msalandurllib3at each verbosity.Compatibility
Config, CLI flags, exit codes, the dataset and the API v2 definition copy are unchanged. Report output: the egress PDF's scope table loses the credential rows.
run.log: no MSAL debug lines at any verbosity, and no urllib3 debug lines below-vv.