Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .server-changes/sort-team-members-alphabetically.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
area: webapp
type: fix
---

Team members and pending invites on the organization Team page are now listed in alphabetical order.
12 changes: 11 additions & 1 deletion apps/webapp/app/models/member.server.ts
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,17 @@ export async function getTeamMembersAndInvites({
return null;
}

return { members: org.members, invites: org.invites };
// Prisma can't express "order by name, falling back to email when unset"
// case-insensitively in a single nested orderBy, so sort in JS here.
const byDisplayName = (a: string, b: string) =>
a.localeCompare(b, undefined, { sensitivity: "base" });

const members = [...org.members].sort((a, b) =>
byDisplayName(a.user.name ?? a.user.email, b.user.name ?? b.user.email)
);
const invites = [...org.invites].sort((a, b) => byDisplayName(a.email, b.email));

return { members, invites };
}

export async function inviteMembers({
Expand Down
Loading