Repository navigation
Fix OrderingFilter labels for annotations with ordering_fields='__all__' - #10073
Open
mohamed-alired wants to merge 1 commit into
Open
mohamed-alired wants to merge 1 commit into
mohamed-alired wants to merge 1 commit into
Conversation
The label for an annotated field was built with key.title().split('__'),
a list, so the browsable API's ordering menu showed e.g.
"['Related', 'Count'] - ascending". Join the parts into a string
("Related Count - ascending"), like the labels of model fields.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
With
ordering_fields = '__all__',OrderingFilter.get_valid_fields()builds the label of an annotated field withkey.title().split('__'), which is a list. The browsable API's ordering menu then shows its repr:This change joins the parts into a string ("Related Count - ascending"), like the labels of model fields next to it.
Tests:
test_get_template_context_annotation_labelchecks the rendered label. It fails onmainand passes with this change.