Repository navigation
Keep the text before a binding that follows a literal %{} - #444
Merged
whatyouhide merged 1 commit intoOct 15, 2026
Merged
whatyouhide merged 1 commit into
whatyouhide merged 1 commit into
Conversation
While splitting a string into interpolation segments, a literal "%{}" is
appended to the current segment and the scan continues. If a binding then
followed, that segment was dropped instead of being flushed before the
binding, so "a %{} b %{c}" interpolated to " b X" at runtime and at compile
time alike.
Contributor
|
Great find @oliver-kriska 🫶 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While splitting a message into interpolation segments,
Gettext.Interpolation.Default.to_interpolatable/1appends a literal%{}to the current segment and keeps scanning. If a binding follows, that segment was dropped instead of being flushed before the binding:The same function builds the compiled interpolation, so translations containing a literal
%{}before a binding lost text at compile time as well. The fix flushes the current segment together with the text before the binding; a literal%{}at the end of a string or in a string without bindings was already handled.Found while checking output equivalence of an unrelated interpolation change against the previous implementation; tests added for both the segments and the interpolated result.