Repository navigation
Index existing messages in merge_template/3 instead of a linear find per message - #443
Merged
whatyouhide merged 2 commits intoOct 13, 2026
Merged
Conversation
merge_template/3 called Expo.Messages.find/2 once per message, and find/2 walks the whole list, so merging was quadratic in the catalogue size. Look messages up by key instead. The first message for a key wins, as with find/2, so the output is unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
|
@mstroeck lovely find, can we add a regression test with two new messages that have the same key but different references and extracted comments? Just to make sure the map behavior doesn't break that. |
Two new messages with the same key but different references and extracted comments: an existing message merges with the first of them, and when no existing message has the key both are kept in order. Both cases behave the same with Messages.find/2 and with the key index. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Author
|
Added two regression tests for the duplicate-key case - an existing message merges with the first of the two new ones, and without an existing message both are kept in order. Both pass against the old and the indexed implementation, so behaviour is unchanged. Thanks for the review! |
josevalim
approved these changes
Oct 13, 2026
Contributor
|
Lovely, thank you @mstroeck! 💟 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extraction got very slow on our catalogue -
merge_template/3callsExpo.Messages.find/2once per message, andfind/2walks the whole list, so the merge is O(n²).On our
default.pot(~25.9k msgids)merge_template/3alone takes 224.7s. With this change it takes 0.307s (~730x), with byte-identical output.What changed:
find/2per messagefind/2, so duplicate keys behave exactly as beforeHow I checked it:
sort_by_msgidmodesHappy to add a benchmark or a regression test to the repo if you'd like one.
Thanks!