Skip to content

ci: use the shared tools copyright hook - #34

Merged
AlexanderLanin merged 1 commit into
mainfrom
steward/eclipse-score-coverage-tool/work-1753a8071720
Oct 9, 2026
Merged

AlexanderLanin merged 1 commit into
mainfrom
steward/eclipse-score-coverage-tool/work-1753a8071720

Conversation

@AlexanderLanin

Copy link
Copy Markdown
Member

Why

Use the copyright checker from eclipse-score/tools for both local pre-commit checks and CI, replacing the repository’s Bazel-based check.

  • Add the copyright pre-commit hook pinned to v0.0.2 and run it against all files in CI.
  • Remove the obsolete Bazel copyright target and its README command.
  • Retain score_tooling because lint aspects, unit-test macros, and the Dash license checker still depend on it.

Closes #28

@github-actions

github-actions Bot commented Oct 9, 2026

Copy link
Copy Markdown
Contributor

License Check Results

🚀 The license check job ran with the Bazel command:

bazel run //:license-check

Status: ⚠️ Needs Review

Click to expand output
[License Check Output]
2026/10/09 00:06:06 Downloading https://releases.bazel.build/8.6.0/release/bazel-8.6.0-linux-x86_64...
Extracting Bazel installation...
Starting local Bazel server (8.6.0) and connecting to it...
INFO: Invocation ID: b5e8c978-b736-461d-b388-a2d19f3d6b5d
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Loading: 
Loading: 0 packages loaded
Loading: 0 packages loaded
Analyzing: target //:license-check (1 packages loaded, 0 targets configured)
Analyzing: target //:license-check (1 packages loaded, 0 targets configured)

Analyzing: target //:license-check (5 packages loaded, 6 targets configured)

Analyzing: target //:license-check (5 packages loaded, 6 targets configured)

Analyzing: target //:license-check (5 packages loaded, 6 targets configured)

Analyzing: target //:license-check (5 packages loaded, 6 targets configured)

Analyzing: target //:license-check (5 packages loaded, 6 targets configured)

Analyzing: target //:license-check (5 packages loaded, 6 targets configured)

Analyzing: target //:license-check (68 packages loaded, 10 targets configured)

Analyzing: target //:license-check (80 packages loaded, 10 targets configured)

Analyzing: target //:license-check (129 packages loaded, 82 targets configured)

Analyzing: target //:license-check (151 packages loaded, 3277 targets configured)

Analyzing: target //:license-check (151 packages loaded, 3277 targets configured)

Analyzing: target //:license-check (151 packages loaded, 3277 targets configured)

Analyzing: target //:license-check (162 packages loaded, 7358 targets configured)

Analyzing: target //:license-check (166 packages loaded, 9773 targets configured)

Analyzing: target //:license-check (173 packages loaded, 9824 targets configured)

Analyzing: target //:license-check (177 packages loaded, 11832 targets configured)

Analyzing: target //:license-check (177 packages loaded, 11832 targets configured)

Analyzing: target //:license-check (178 packages loaded, 11949 targets configured)

Analyzing: target //:license-check (178 packages loaded, 11949 targets configured)

Analyzing: target //:license-check (178 packages loaded, 11949 targets configured)

INFO: Analyzed target //:license-check (179 packages loaded, 12076 targets configured).
[12 / 16] JavaToolchainCompileClasses external/rules_java+/toolchains/platformclasspath_classes; 0s disk-cache, processwrapper-sandbox ... (2 actions running)
[15 / 16] Building tools/license.check.license_check.jar (); 0s disk-cache, multiplex-worker
INFO: Found 1 target...
Target //tools:license.check.license_check up-to-date:
  bazel-bin/tools/license.check.license_check
  bazel-bin/tools/license.check.license_check.jar
INFO: Elapsed time: 37.832s, Critical Path: 1.70s
INFO: 16 processes: 12 internal, 3 processwrapper-sandbox, 1 worker.
INFO: Build completed successfully, 16 total actions
INFO: Running command line: bazel-bin/tools/license.check.license_check tools/formatted.txt <args omitted>
usage: org.eclipse.dash.licenses.cli.Main [-batch <int>] [-cd <url>]
       [-confidence <int>] [-ef <url>] [-excludeSources <sources>] [-help] [-lic
       <url>] [-project <shortname>] [-repo <url>] [-review] [-summary <file>]
       [-timeout <seconds>] [-token <token>]

@github-actions

github-actions Bot commented Oct 9, 2026

Copy link
Copy Markdown
Contributor

Documentation preview for this pull request is available at:
pr-34: https://eclipse-score.github.io/coverage_tool/pr-34/

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The pinned hook allows malformed copyright headers to pass CI.

1 open finding
What changed in this PR

Replaces the Bazel copyright check with the shared pre-commit hook for local and CI use.

Changes:

  • Adds the shared copyright hook.
  • Updates CI to run it across all files.
  • Removes obsolete Bazel configuration and documentation.
File Description
.pre-commit-config.yaml Adds the shared copyright hook.
.github/​workflows/​copyright.yml Runs the hook in CI.
tools/​BUILD Removes the Bazel copyright target.
README.md Updates development instructions.

🧠 Review effort: Balanced


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread .pre-commit-config.yaml
Comment on lines +33 to +35
rev: v0.0.2
hooks:
- id: copyright

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bug reported at eclipse-score/tools#25, so it will be fixed here via simple update

@AlexanderLanin
AlexanderLanin merged commit 0978cdd into main Oct 9, 2026
11 checks passed
@AlexanderLanin
AlexanderLanin deleted the steward/eclipse-score-coverage-tool/work-1753a8071720 branch October 9, 2026 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

update copyright check to use the one from tools

3 participants