Repository navigation
ci: run formatting checks through pre-commit using devcontainer tools - #32
Merged
AlexanderLanin merged 3 commits intoOct 8, 2026
Merged
Conversation
Contributor
License Check Results🚀 The license check job ran with the Bazel command: bazel run //:license-checkStatus: Click to expand output |
AlexanderLanin
commented
Oct 8, 2026
Contributor
|
What about copyright_checker? |
Contributor
|
Documentation preview for this pull request is available at: |
AlexanderLanin
force-pushed
the
steward/eclipse-score-coverage-tool/work-c8cc91bf7864
branch
from
October 8, 2026 14:20
7f74624 to
1507b64
Compare
There was a problem hiding this comment.
🟢 Approval recommended
The formatting migration is coherent, preserves the intended checks, and introduces no unresolved correctness issues.
0 open findings
What changed in this PR
Moves repository formatting checks from Bazel targets to pre-commit using the shared devcontainer tool catalog.
Changes:
- Adds Ruff, Buildifier, and yamlfmt pre-commit hooks.
- Updates CI, Bazel dependencies, lockfile, and developer instructions.
- Modernizes numeric type validation for Ruff compatibility.
| File | Description |
|---|---|
.github/workflows/format.yml |
Runs pre-commit formatting checks. |
.pre-commit-config.yaml |
Defines formatter hooks using devcontainer tools. |
MODULE.bazel |
Adds the devcontainer dependency. |
MODULE.bazel.lock |
Updates resolved dependencies. |
README.md |
Documents the new formatting command. |
score_coverage/generate_coverage_html.py |
Uses union syntax in numeric validation. |
tools/BUILD |
Removes obsolete formatting targets. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
AlexanderLanin
marked this pull request as ready for review
October 8, 2026 18:52
AlexanderLanin
requested review from
MaximilianSoerenPollak,
dcalavrezo-qorix and
nradakovic
as code owners
October 8, 2026 18:52
AlexanderLanin
commented
Oct 8, 2026
MaximilianSoerenPollak
approved these changes
Oct 8, 2026
AlexanderLanin
deleted the
steward/eclipse-score-coverage-tool/work-c8cc91bf7864
branch
October 8, 2026 19:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Update formatting checks to run through pre-commit on the host runner, using the shared Eclipse S-CORE devcontainer tool catalog while retaining Python, Starlark, and YAML checks.
pre-commit/action@v3.0.1.score_devcontainer1.11.0 as a development dependency.int | floatin coverage-value validation, preserving the explicit rejection of booleans.Closes #29
🤖 Behind this PR
This PR came through an AI-assisted engineering workflow:
AI-assisted, human-guided.