Skip to content

Mark removal for unused deprecated methods in o.e.compare - #2195

Merged
akurtakov merged 1 commit into
eclipse-platform:masterfrom
SougandhS:MarkDeprecatedForRemoval
Dec 16, 2025
Merged

akurtakov merged 1 commit into
eclipse-platform:masterfrom
SougandhS:MarkDeprecatedForRemoval

Conversation

@SougandhS

Copy link
Copy Markdown
Contributor

No description provided.

merks
merks previously requested changes Oct 10, 2025
@SougandhS
SougandhS force-pushed the MarkDeprecatedForRemoval branch 2 times, most recently from e8b26eb to 83f44e6 Compare October 10, 2025 06:18
@github-actions

github-actions Bot commented Oct 10, 2025 •

Copy link
Copy Markdown
Contributor

Test Results

 1 953 files  ±0   1 953 suites  ±0   1h 24m 52s ⏱️ - 5m 53s
 4 744 tests ±0   4 720 ✅ ±0   24 💤 ±0  0 ❌ ±0 
14 232 runs  ±0  14 050 ✅ ±0  182 💤 ±0  0 ❌ ±0 

Results for commit dadc46a. ± Comparison against base commit 6a25ff1.

♻️ This comment has been updated with latest results.

@SougandhS
SougandhS force-pushed the MarkDeprecatedForRemoval branch from 83f44e6 to 435fc5c Compare October 14, 2025 01:06
@SougandhS
SougandhS force-pushed the MarkDeprecatedForRemoval branch from 435fc5c to f14e249 Compare October 14, 2025 08:51
@SougandhS
SougandhS requested a review from merks October 14, 2025 09:38
@SougandhS
SougandhS force-pushed the MarkDeprecatedForRemoval branch 2 times, most recently from 5b25b26 to e43c04c Compare October 17, 2025 09:25
@SougandhS

Copy link
Copy Markdown
Contributor Author

Hi @merks
Could you please re-review this when you get time ?

@SougandhS
SougandhS force-pushed the MarkDeprecatedForRemoval branch from e43c04c to e102211 Compare October 19, 2025 10:37
@SougandhS
SougandhS force-pushed the MarkDeprecatedForRemoval branch from e102211 to 18756f6 Compare October 30, 2025 02:31
@SougandhS
SougandhS force-pushed the MarkDeprecatedForRemoval branch 2 times, most recently from d793ecc to 29edbed Compare November 8, 2025 03:15
@SougandhS

Copy link
Copy Markdown
Contributor Author

Hi @merks, the build looks good now, if there are no more changes can this be merged ?

@akurtakov
akurtakov force-pushed the MarkDeprecatedForRemoval branch 2 times, most recently from 79a0565 to 135fc9b Compare December 12, 2025 05:43
@akurtakov

Copy link
Copy Markdown
Member

Please change the since to 2026-03 as 2025-12 is done deal now.

@SougandhS
SougandhS force-pushed the MarkDeprecatedForRemoval branch 2 times, most recently from 4337cef to 2eefbcf Compare December 12, 2025 06:27
@SougandhS

Copy link
Copy Markdown
Contributor Author

Please change the since to 2026-03 as 2025-12 is done deal now.

Updated now 👍

@SougandhS
SougandhS force-pushed the MarkDeprecatedForRemoval branch from 2eefbcf to dadc46a Compare December 16, 2025 06:34
@akurtakov
akurtakov dismissed merks’s stale review December 16, 2025 07:04

Dismissing as the request was fullfilled.

@akurtakov
akurtakov merged commit 2605191 into eclipse-platform:master Dec 16, 2025
18 checks passed
@SougandhS

Copy link
Copy Markdown
Contributor Author

Thank you all..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants