Repository navigation
Lay out the hosted view of a shown trim stack without a resize hack - #4492
Merged
akurtakov merged 1 commit intoOct 19, 2026
Merged
Conversation
Commit 04a1460 ("Fix for Bug 434062 - [Perspectives] Console View "clipped" when switching Perspectives") made TrimStack shrink the CTabFolder by one pixel when showing a minimized stack, so that the resulting resize would lay out the hosted view at the right size. This left the folder one pixel narrower until the next layout and relied on a bounds change to trigger the layout. The CTabFolder is now laid out explicitly, including its children, after the host pane is laid out, so the hosted view fills the folder even when the folder keeps its bounds while the view was laid out elsewhere, e.g. in another perspective. TrimStackTest covers showing a stack again after its part was resized. Assisted-by: Anthropic Claude Code (claude-opus-5-5)
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
Static review found no blocking issues in the focused layout change or regression test; tests were not executed.
0 open findings
What changed in this PR
Replaces the minimized-stack resize workaround with explicit layout so hosted views fill their available space without changing folder bounds.
Changes:
- Explicitly lays out the tab folder and its children after the host pane.
- Adds and registers a regression test for showing a stack after its part was resized.
| File | Description |
|---|---|
| tests/org.eclipse.e4.ui.workbench.addons.swt.test/src/org/eclipse/e4/ui/workbench/addons/minmax/TrimStackTest.java | Tests hosted-view sizing when showing a stack again. |
| tests/org.eclipse.e4.ui.workbench.addons.swt.test/src/org/eclipse/e4/ui/workbench/addons/AllTests.java | Registers the regression test. |
| bundles/org.eclipse.e4.ui.workbench.addons.swt/src/org/eclipse/e4/ui/workbench/addons/minmax/TrimStack.java | Replaces one-pixel shrinking with explicit layout. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit 04a1460 ("Fix for Bug 434062 - [Perspectives] Console View "clipped" when switching Perspectives") made
TrimStackshrink theCTabFolderby one pixel when showing a minimized stack, so that the resulting resize would lay out the hosted view at the right size. This left the folder one pixel narrower until the next layout and relied on a bounds change to trigger the layout.The
CTabFolderis now laid out explicitly, including its children, after the host pane is laid out, so the hosted view fills the folder even when the folder keeps its bounds while the view was laid out elsewhere, e.g. in another perspective.The new
TrimStackTestcovers showing a stack again after its part was resized.