Repository navigation
Let the editor onboarding content follow the container background - #4485
Merged
vogella merged 1 commit intoOct 13, 2026
Merged
Conversation
The onboarding controls of an empty editor stack copied the folder background into their composites once, at creation. This went unnoticed while the CSS engine skipped the container, but now that it styles every non-page child of a CTabFolder, the container takes the theme color and the inner composite keeps the stale one. With the Light theme on GTK this showed a white box on the grey editor area. The container now forces its background onto its children. Fixes eclipse-platform#4484 Assisted-by: multiple AI agents and layers of automated tooling 🤖
Contributor
marcushoepfner
approved these changes
Oct 13, 2026
marcushoepfner
left a comment
marcushoepfner
left a comment
Contributor
There was a problem hiding this comment.
thanks for fixing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The onboarding controls of an empty editor stack copied the folder background into their composites once, at creation. Now that the CSS engine also styles non-page children of a CTabFolder, the onboarding container takes the theme color while the inner composite keeps the stale one, which shows up as a white box on the grey editor area with the Light theme on GTK. The container now forces its background onto its children, so the image, the text and the shortcut labels always match the editor area, including after a theme switch or a change of the active stack. A new StackRendererTest case covers it.
Fixes #4484