Repository navigation
Ignore the shell frame shadow in CodeMiningTest pixel scans - #4483
Merged
Merged
Conversation
Without a window manager, as under Xvfb, GTK paints a two pixel shadow along the right shell edge, which the full-width pixel scans mistook for rendered code minings. Assisted-by: multiple AI agents and layers of automated tooling 🤖
Contributor
Contributor
Author
|
Allows to run this test in a virtual x-server without the last pixels ignore it fails locally. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without a window manager, for example under Xvfb, GTK paints a two pixel frame shadow along the right edge of the shell. The pixel scans in
CodeMiningTestcovered the full widget width and mistook that shadow for a rendered code mining, which madetestCodeMiningMultiLine,testCodeMiningEndOfLineandtestMultiLineHeaderCodeMiningfail headless. The scans now stop a few pixels short of the right edge, so the tests pass both under Xvfb and on a real desktop while still detecting actual minings.