Repository navigation
Conversation
CTabFolderWrapper read CTabFolder's selection gradient through the field name "selectionGradientColorsField", which does not exist, so the lookup walked the class hierarchy and threw NoSuchFieldException on every call and always returned null. Selected tabs therefore always fell back to white, and the selection gradient percents were discarded. Drop the two selection gradient accessors and go straight to that fallback for selected tabs, which keeps the rendering unchanged. Assisted-by: multiple AI agents and layers of automated tooling 🤖
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CTabRendering's CTabFolderWrapper read the selection gradient of CTabFolder reflectively through the field name "selectionGradientColorsField", which does not exist. The lookup therefore walked the class hierarchy and threw a NoSuchFieldException on every tab paint, and it always returned null, so selected tabs always fell back to white. This removes the two selection gradient accessors and their fields and goes straight to that fallback, which keeps the rendering identical while dropping the reflective lookup and the exception from the paint path.