Repository navigation
Create the value diff only when a property value changed - #4477
Merged
vogella merged 1 commit intoOct 12, 2026
Merged
Conversation
SimplePropertyObservableValue checks for a change on every getValue() and setValue() once it has listeners, and created a ValueDiff before comparing the old and new value. For the common unchanged read the diff was discarded right away. Create the diff only when a change event is fired. Assisted-by: multiple AI agents and layers of automated tooling 🤖
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SimplePropertyObservableValue re-reads the property on every getValue() and setValue() once it has listeners, and it created a ValueDiff before checking whether the value had changed at all. In the common case of an unchanged read that diff was thrown away immediately. The diff is now created only when a change event is actually fired, which removes a short-lived allocation from every observed property access without changing what listeners receive.