Repository navigation
Ignore ALT_GR when considering to hide content assists - #3330
fhackenberger wants to merge 1 commit into
Conversation
Test Results 3 024 files ±0 3 024 suites ±0 2h 14m 4s ⏱️ - 2m 40s For more details on these failures, see this check. Results for commit a4597e0. ± Comparison against base commit 89a19bf. ♻️ This comment has been updated with latest results. |
|
The failed test NestedResourcesTest#testProjectHierarchy seems to be completely unrelated to my change. |
f745bd6 to
e82918e
Compare
|
@akurtakov I was wondering if your push means that you're looking into this to merge it? I'm not familiar with the workflow you're using for eclipse. |
|
In general yes - I'm just overloaded with things which leads to huge delays. Would you please rebase on master to fix conflicts? |
e82918e to
623f591
Compare
|
@akurtakov Sorry for the delay, I've rebased on master of today. Please see if you could merge it now. |
On Linux ALT_GR is the level3 switch (at least on the US-INTL layout), when using 'include "level3(YOURKEY)"' in the xkb file.
623f591 to
a4597e0
Compare
|
Sorry I missed one of the conflicts. Fixed now. |
akurtakov
left a comment
akurtakov
left a comment
There was a problem hiding this comment.
Looks good now. We are in RC2 now so this will have to wait for next stream to be opened.
|
Could that change have negative side effects on other platforms like Windows or macOS? |
|
@BeckerWdf I don't see how this could have negative side effects. ALT_GR is clearly a modifier key. Closing a pop-up with a modifier key doesn't really make sense on any platform, as they are often used for navigation. |
On Linux ALT_GR is the level3 switch (at least on the US-INTL layout), when using 'include "level3(YOURKEY)"' in the xkb file. Pressing it should leave the content assist open.
I've remapped Caps-Lock as the level3 switch and changed the keyboard layout, so I can use CapsLock-h/j/k/l instead of the arrow keys. This works in all applications I use on my Gnome desktop, except for the eclipse autocomplete popups, which is quite annoying as I'm using eclipse as my main IDE for backend development.