Repository navigation
Conversation
Fixes eclipse-platform#3752 A Win32 subitem hit test can return a valid row with column -1 for a point outside the table. Tooltip positioning then indexes a per-cell font array with that column. Rejected invalid hits before acquiring a device context and retained the row-font fallback for invalid font indices. Added Win32 regressions covering zero, one and 22 explicit columns, including the implicit first column and valid tooltip measurement. Compiled all 651 Win32 Java sources against their matching native libraries. Native Windows Java 21 passed all six new cases. Unmodified code failed all six; reverting either guard failed its three cases. The full Tycho test matrix was not run locally, and the original spontaneous hover is not automated. Signed-off-by: Frédéric Desbiens <frederic.desbiens@eclipse-foundation.org> Assisted-by: Codex (gpt-6) <noreply@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3752
A Win32 subitem hit test can return a valid row with column -1 for a point outside the table. Tooltip positioning then indexes a per-cell font array with that column.
Rejected invalid hits before acquiring a device context and retained the row-font fallback for invalid font indices. Added Win32 regressions covering zero, one and 22 explicit columns, including the implicit first column and valid tooltip measurement.
Compiled all 651 Win32 Java sources against their matching native libraries. Native Windows Java 21 passed all six new cases. Unmodified code failed all six; reverting either guard failed its three cases. The full Tycho test matrix was not run locally, and the original spontaneous hover is not automated.