Repository navigation
Conversation
On Wayland the MouseDown of the left button is held in dragDetectionQueue when the control wants drag detection, until the mouse is released or a drag starts. MouseDoubleClick was not held, so with a DragDetect listener or a DragSource the second press of a double click delivered MouseDoubleClick before MouseDown, and also before the DefaultSelection of a Table or Tree. When MouseDoubleClick arrives, send the held MouseDown first. The queue stays for the drag detection of the press, and the MouseDown is not sent again when the queue is flushed.
There was a problem hiding this comment.
🔵 Needs a closer look
Native event ordering and retained drag-detection state need GTK3/GTK4 Wayland runtime validation.
No open issues 🎉
What changed in this PR
Fixes GTK Wayland mouse-event ordering when drag detection delays MouseDown.
Changes:
- Delivers the queued
MouseDownbeforeMouseDoubleClickwhile retaining drag-detection state. - Prevents duplicate
MouseDowndelivery when the queue is flushed.
| File | Description |
|---|---|
| bundles/org.eclipse.swt/Eclipse SWT/gtk/org/eclipse/swt/widgets/Control.java | Tracks early MouseDown delivery and adjusts drag-queue flushing. |
Review effort: Balanced
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Wayland the MouseDown of the left button is held in dragDetectionQueue when the control wants drag detection, until the mouse is released or a drag starts. MouseDoubleClick was not held, so with a DragDetect listener or a DragSource the second press of a double click delivered MouseDoubleClick before MouseDown, and also before the DefaultSelection of a Table or Tree.
When MouseDoubleClick arrives, send the held MouseDown first. The queue stays for the drag detection of the press, and the MouseDown is not sent again when the queue is flushed.