Repository navigation
[GTK4] Send MouseDown before MouseDoubleClick on a double click - #3748
Merged
akurtakov merged 1 commit intoOct 19, 2026
Merged
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
Wayland deferral still reverses event delivery, and asynchronous dispatch prevents cancellation from claiming the gesture sequence.
2 open issues
What changed in this PR
Aligns GTK4 double-click dispatch with other SWT platforms, addressing part of #3743.
Changes:
- Calls MouseDown before MouseDoubleClick.
- Combines dispatch results and adds a disposal check.
| File | Description |
|---|---|
| bundles/org.eclipse.swt/Eclipse SWT/gtk/org/eclipse/swt/widgets/Control.java | Updates GTK4 double-click event ordering and gesture-result handling. |
Review effort: Balanced
Contributor
akurtakov
force-pushed
the
gtk4-double-click-order
branch
from
October 19, 2026 11:11
d650929 to
891f1b5
Compare
On the second press of a double click GTK4 sent MouseDoubleClick before MouseDown, and it sent MouseDoubleClick again on a third press. GTK3, Win32 and Cocoa send MouseDown with count 2 first and then MouseDoubleClick, so code that handles the press in MouseDown saw the double click first. GTK3 sends no MouseDoubleClick for a third press. Part of eclipse-platform#3743.
akurtakov
force-pushed
the
gtk4-double-click-order
branch
from
October 19, 2026 13:31
891f1b5 to
9e43563
Compare
vogella
added a commit
to vogella/eclipse.platform.swt
that referenced
this pull request
Oct 19, 2026
Takes upstream's GTK4 MouseDown before MouseDoubleClick (eclipse-platform#3748) in place of the fork's own version of that fix. Assisted-by: multiple AI agents and layers of automated tooling 🤖
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On the second press of a double click GTK4 sent MouseDoubleClick before
MouseDown, and it sent MouseDoubleClick again on a third press. GTK3,
Win32 and Cocoa send MouseDown with count 2 first and then
MouseDoubleClick, so code that handles the press in MouseDown saw the
double click first. GTK3 sends no MouseDoubleClick for a third press.
Part of #3743.