Repository navigation
[GTK] Focus the first or last link when Tab moves the focus into a Link - #3746
Merged
Merged
Conversation
Link kept the index of the focused link when it lost focus. After Tab moved past the last link, the next Tab into the Link focused the last link again and the following Tab left it, so the other links could no longer be reached with Tab. Shift+Tab never got past the first link. Focus the first link on Tab and the last link on Shift+Tab.
There was a problem hiding this comment.
🟢 Approval recommended
The narrow change addresses repeated keyboard traversal correctly, with no unresolved findings.
No open issues 🎉
What changed in this PR
Fixes GTK Link keyboard traversal so entering the widget selects the appropriate link.
Changes:
- Focuses the first link on Tab and the last link on Shift+Tab.
- Redraws after updating focus while preserving superclass focus-failure handling.
| File | Description |
|---|---|
| bundles/org.eclipse.swt/Eclipse SWT/gtk/org/eclipse/swt/widgets/Link.java | Overrides tab-item focus to select the link based on traversal direction. |
Review effort: Balanced
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link kept the index of the focused link when it lost focus. After Tab moved past the last link, the next Tab into the Link focused the last link again and the following Tab left it, so the other links could no longer be reached with Tab. Shift+Tab never got past the first link.
Focus the first link on Tab and the last link on Shift+Tab.