Repository navigation
Conversation
The asyncExec test lost its implicit UI thread check when its Display.beep() runnable was replaced by a silent one. Run the queued runnable before disposing the display and assert that it ran on the display thread. Assisted-by: multiple AI agents and layers of automated tooling 🤖
Contributor
HeikoKlare
approved these changes
Oct 19, 2026
HeikoKlare
left a comment
HeikoKlare
left a comment
Contributor
There was a problem hiding this comment.
Looks good, thank you.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #3741, which replaced the Display.beep() runnable of the asyncExec test with a silent one and so removed the test's implicit check that the runnable runs on the UI thread. The test now runs the queued runnable with a readAndDispatch loop before disposing the display, asserts inside it that Display.getCurrent() is the display, and asserts that it ran. That restores the thread check without the alert sound and additionally catches an asyncExec that never runs its runnable, which the beep version could not.