Skip to content

fix(ci): drop postPublish from the release publish script and stop tagging the tests package - #349

Merged
mishushakov merged 1 commit into
mainfrom
devin/1791479826-fix-release-publish
Oct 9, 2026
Merged

mishushakov merged 1 commit into
mainfrom
devin/1791479826-fix-release-publish

Conversation

@devin-ai-integration

Copy link
Copy Markdown
Contributor

Summary

The release run for template 0.4.7 failed in its publish step:

pnpm changeset publish && pnpm run -r postPublish
 ERR_PNPM_RECURSIVE_RUN_NO_SCRIPT  None of the selected packages has a "postPublish" script

The only postPublish script was the Poetry PyPI upload in python/package.json, which #332 removed. That left the root publish script failing on every release. Because the step failed, changesets/action never pushed the tags or created the GitHub release, but "Push new versions" still pushed the version commit to main.

  • package.json: "publish": "pnpm changeset publish" (no package has a postPublish hook anymore).
  • tests/package.json: drop "version". With privatePackages.tag: true, changesets tagged the private test project as @e2b/code-interpreter-tests@0.0.0. shouldSkipPackage skips packages that have no version, so it is no longer versioned or tagged.

The missing @e2b/code-interpreter-template@0.4.7 tag has been pushed by hand at 1d3de45.

Link to Devin session: https://app.devin.ai/sessions/2330ee3ef3e94a26bdeadb5f068f4bac
Open in Devin Desktop: https://app.devin.ai/desktop/session/2330ee3ef3e94a26bdeadb5f068f4bac?variant=devin
Requested by: @mishushakov

…gging the tests package

Co-Authored-By: mish@e2b.dev <mish@e2b.dev>
@devin-ai-integration

Copy link
Copy Markdown
Contributor Author

I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".

  • Disable automatic comment, CI, and merge conflict monitoring

@cla-bot cla-bot Bot added the cla-signed label Oct 8, 2026
@mishushakov
mishushakov marked this pull request as ready for review October 9, 2026 14:17
@mishushakov
mishushakov self-requested a review as a code owner October 9, 2026 14:17
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-09T14:18:51.688763Z d7f4bcc Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@mishushakov
mishushakov enabled auto-merge (squash) October 9, 2026 14:17
@mishushakov
mishushakov merged commit a4934a5 into main Oct 9, 2026
12 checks passed
@mishushakov
mishushakov deleted the devin/1791479826-fix-release-publish branch October 9, 2026 14:18

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed this PR and didn't find any bugs. Every path in the repo is covered by a CODEOWNERS entry, and this change touches the release pipeline, so the code owner should still take a look.

What was reviewed:

  • Searched every workspace package.json for a postPublish script and found none, so dropping pnpm run -r postPublish doesn't skip any work. The version script still runs postVersion recursively, which chart_data_extractor needs.
  • Checked .changeset/config.json: privatePackages.tag: true explains why tests was being tagged. tests is still in pnpm-workspace.yaml and still private, and none of its scripts reference a version.
Extended reasoning...

This change edits two package.json files. The root publish script no longer calls the recursive postPublish, which no package defines anymore. The private tests workspace package loses its placeholder 0.0.0 version, so changesets stops versioning and tagging it. It touches no injection, auth or data-exposure surface. The change is small and looks correct, but CODEOWNERS assigns every path to a single owner, and it affects how releases are tagged and published, so I'm deferring rather than approving.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant