Repository navigation
fix(ci): drop postPublish from the release publish script and stop tagging the tests package - #349
Conversation
…gging the tests package Co-Authored-By: mish@e2b.dev <mish@e2b.dev>
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
I reviewed this PR and didn't find any bugs. Every path in the repo is covered by a CODEOWNERS entry, and this change touches the release pipeline, so the code owner should still take a look.
What was reviewed:
- Searched every workspace package.json for a
postPublishscript and found none, so droppingpnpm run -r postPublishdoesn't skip any work. Theversionscript still runspostVersionrecursively, whichchart_data_extractorneeds. - Checked
.changeset/config.json:privatePackages.tag: trueexplains whytestswas being tagged.testsis still inpnpm-workspace.yamland still private, and none of its scripts reference a version.
Extended reasoning...
This change edits two package.json files. The root publish script no longer calls the recursive postPublish, which no package defines anymore. The private tests workspace package loses its placeholder 0.0.0 version, so changesets stops versioning and tagging it. It touches no injection, auth or data-exposure surface. The change is small and looks correct, but CODEOWNERS assigns every path to a single owner, and it affects how releases are tagged and published, so I'm deferring rather than approving.
Summary
The release run for template 0.4.7 failed in its publish step:
The only
postPublishscript was the Poetry PyPI upload inpython/package.json, which #332 removed. That left the rootpublishscript failing on every release. Because the step failed, changesets/action never pushed the tags or created the GitHub release, but "Push new versions" still pushed the version commit to main.package.json:"publish": "pnpm changeset publish"(no package has apostPublishhook anymore).tests/package.json: drop"version". WithprivatePackages.tag: true, changesets tagged the private test project as@e2b/code-interpreter-tests@0.0.0.shouldSkipPackageskips packages that have noversion, so it is no longer versioned or tagged.The missing
@e2b/code-interpreter-template@0.4.7tag has been pushed by hand at 1d3de45.Link to Devin session: https://app.devin.ai/sessions/2330ee3ef3e94a26bdeadb5f068f4bac
Open in Devin Desktop: https://app.devin.ai/desktop/session/2330ee3ef3e94a26bdeadb5f068f4bac?variant=devin
Requested by: @mishushakov