Skip to content

Keep public integration checkout paths literal - #159

Merged
rmcdaniel merged 2 commits into
mainfrom
fix/public-checkout-literal-destination
Oct 17, 2026
Merged

rmcdaniel merged 2 commits into
mainfrom
fix/public-checkout-literal-destination

Conversation

@rmcdaniel

@rmcdaniel rmcdaniel commented Oct 17, 2026 •

Copy link
Copy Markdown
Member

Refs #158.

End Git option parsing before the fixed public repository URL and destination.
Names such as --bare and --mirror now select literal working-tree paths.
The repository allowlist, disabled credential helper, full lowercase SHA
validation and resolved-commit check remain unchanged.

Real local Git regressions fail on the parent: both names produce a bare
source.git rather than the requested directory. The corrected helper passes
all 20 checkout tests, including default-branch and exact-commit clones
into both names, rejected malformed SHAs and existing public-authority checks.
Ruff passes for both changed files. Tests permit only the local file protocol;
they do not access a remote repository.

This addresses a concrete behavior found while reviewing Sonar
pythonsecurity:S8705. No customer impact or remote-execution exploit is
claimed. All ten exact candidate CI jobs pass, including actual HTTP integration.
Sonar's exact PR report passes with zero OPEN/CONFIRMED findings and 0.0% new
duplication. Independent merged-main CI 39017930118 also passes all ten jobs,
and main's official Sonar app passes on ceb0cd79365255f5575dd745145b9af557f9d0b1.
The reviewed tree is unchanged. Issue #158 is closed; no release is needed.
No SDK runtime, version, dependency, release or protocol changes.

@sonarqubecloud

Copy link
Copy Markdown

@rmcdaniel
rmcdaniel marked this pull request as ready for review October 17, 2026 08:30
@rmcdaniel
rmcdaniel merged commit ceb0cd7 into main Oct 17, 2026
14 checks passed
@rmcdaniel
rmcdaniel deleted the fix/public-checkout-literal-destination branch October 17, 2026 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants