Repository navigation
test: exercise native HTTPS before release publication - #69
Merged
Merged
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The native release smoke checks cover version, runtime readiness and command listing. They do not make an HTTPS request, leaving #67's outbound TLS acceptance untested on macOS, ARM64 and the Windows streams path before publication.
Run the existing
upgrade --dry-run --output=jsoncommand on every produced native binary before handing its artifact to the publisher. This resolves public latest-release metadata through the normal HTTPS client and leaves the executable unchanged. The ordinary checksum and attestation path binds the published files to those tested bytes.All 39 Node release contracts pass, including a guard that keeps this check ahead of native artifact handoff on both build paths. Application source, permissions and release authority are unchanged. The existing workflow hash remains part of the compiler-cache identity, so merging this follow-up causes the normal warmer to qualify its new identity; no cache provenance is rewritten.
The preceding OpenSSL correction (#68) is merged and its four-target native cold warmer 41178432254 succeeds. No 2.3.2 tag or release is published. Finish this acceptance check and normal native qualification before patch publication; keep #67 open through installed public-asset verification.
Refs #67.