Skip to content

Ensure hasMany() associations work when properties have mapsTo - #679

Merged
dxg merged 2 commits into
dresende:masterfrom
stueynz:master
Dec 1, 2015
Merged

dxg merged 2 commits into
dresende:masterfrom
stueynz:master

Conversation

@stueynz

@stueynz stueynz commented Dec 1, 2015

Copy link
Copy Markdown

Another bug fix when using mapsTo on PK properties. We have to adjust PK property names to matching database name (using mapsTo field in property definition) when setting up JOIN for Many association.

Otherwise the ON part of the JOIN clause will have the property name instead of the database field name when doing the select.

@dxg

dxg commented Dec 1, 2015

Copy link
Copy Markdown
Collaborator

Awesome, thanks!

dxg added a commit that referenced this pull request Dec 1, 2015
Ensure hasMany() associations work when properties have mapsTo
@dxg
dxg merged commit 31c9630 into dresende:master Dec 1, 2015
@dxg

dxg commented Dec 1, 2015

Copy link
Copy Markdown
Collaborator

Released 2.1.28 with this changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants