Feature Question: Can you create indices/indexes with orm on sync()  #98

Activity

1. dresende commented on Apr 7, 2013

   

   dresende

   on Apr 7, 2013

   Owner

   More actions

   Thank you, I never tested performance :)

   Indexes are created for the primary key and associations but I have plans to add them to other properties. I'm going to make some tests and link the commits here for you to try them.
2. dresende

   added a commit that references this issue on Apr 7, 2013

   Adds support for indexes on properties that are no associations (#98)

   ...

   c198765
3. dresende commented on Apr 7, 2013

   

   dresende

   on Apr 7, 2013

   Owner

   More actions

   This adds indexes on single properties. Perhaps another way of adding indexes on groups of properties is also needed, I'm not sure the best and simple syntax to do it (in orm).
4. dresende

   added a commit that references this issue on Apr 7, 2013

   Adds a new option to add multi-column indexes to models (#98)

   ...

   d5c5070
5. dresende commented on Apr 7, 2013

   

   dresende

   on Apr 7, 2013

   Owner

   More actions

   See the notes on the latest commit and see if it fits your needs :)
6. mspisars commented on Apr 8, 2013

   

   mspisars

   on Apr 8, 2013

   Author

   More actions

   This is great... while we're on indexes.
   Tested both PostgreSQL and MySQL, do we need to create the index for "id" since it is a primary key?

   t=# \d person
                                     Table "public.person"
     Column   |          Type          |                      Modifiers
   -----------+------------------------+-----------------------------------------------------
    id        | integer                | not null default nextval('person_id_seq'::regclass)
    name      | character varying(255) |
    surname   | character varying(255) |
    age       | real                   |
    male      | boolean                | not null
    continent | enum_person_continent  |
    photo     | bytea                  |
    data      | bytea                  |
   Indexes:
       "person_pkey" PRIMARY KEY, btree (id)
       "person_id_idx" btree (id)
   

   and

   mysql> show indexes from person;
   +--------+------------+----------+--------------+-------------+-----------+-------------+----------+--------+------+------------+---------+
   | Table  | Non_unique | Key_name | Seq_in_index | Column_name | Collation | Cardinality | Sub_part | Packed | Null | Index_type | Comment |
   +--------+------------+----------+--------------+-------------+-----------+-------------+----------+--------+------+------------+---------+
   | person |          0 | PRIMARY  |            1 | id          | A         |           4 |     NULL | NULL   |      | BTREE      |         |
   | person |          1 | id       |            1 | id          | A         |        NULL |     NULL | NULL   |      | BTREE      |         |
   +--------+------------+----------+--------------+-------------+-----------+-------------+----------+--------+------+------------+---------+

   The above is just a base test with the example data from README.md
7. dresende commented on Apr 8, 2013

   

   dresende

   on Apr 8, 2013

   Owner

   More actions

   I'm not very familiar with postgresql, I don't know if it's necessary or not. Are you sure it's not necessary since the id column is a SERIAL?
8. mspisars commented on Apr 8, 2013

   

   mspisars

   on Apr 8, 2013

   Author

   More actions

   I don't think it is needed for PostgreSQL, but I am not sure about MySQL or SQLite so I guess that was more of a question.
   The index creation syntax looks good, for both multi and single column.
   Thank you for the quick turn around.
9. mspisars

   closed this as completedon Apr 8, 2013
10. dresende commented on Apr 8, 2013

    

    dresende

    on Apr 8, 2013

    Owner

    More actions

    MySQL doesn't need it because of the PRIMARY column. I guess PostgreSQL doesn't also because of SERIAL. I'm going to read about it and remove if not needed.
11. mspisars commented on Apr 8, 2013

    

    mspisars

    on Apr 8, 2013

    Author

    More actions

    Sounds good.
12. dresende

    added 2 commits that reference this issue on Apr 8, 2013

    Removes index on postgresql primary keys

    611fca8

    2.0.8

    ...

    7160fb4