Limit option on Find() not working #93

Activity

1. dresende commented on Mar 26, 2013

   

   dresende

   on Mar 26, 2013

   Owner

   More actions

   Sorry for the late response. There's no limit option in there, but I'm going to add it. You have 2 ways to change your code to have limit:

   1

   req.db.models.Customer.find().limit(req.query.limit).offset(req.query.offset).get(function (err, results) {
       // ...
   });

   2

   req.db.models.Customer.find({}, req.query.limit, { offset: req.query.offset }, function (err, results) {
       // ...
   });

   You can mix them, but limit is not available yet in the .find() options parameter.
2. dresende

   added a commit that references this issue on Mar 26, 2013

   Moves Model.find() limit to options, adds test for it (#93)

   ...

   bf80407
3. dresende

   closed this as completedon Mar 26, 2013
4. gurufaction commented on Mar 27, 2013

   

   gurufaction

   on Mar 27, 2013

   Author

   More actions

   I tried your second suggestion and received an error in "order clause". I will pull your latest code and try that.
5. dresende commented on Mar 27, 2013

   

   dresende

   on Mar 27, 2013

   Owner

   More actions

   That's probably because req.query.limit is a string, it must be a number (use parseInt).
6. gurufaction commented on Mar 28, 2013

   

   gurufaction

   on Mar 28, 2013

   Author

   More actions

   This is the only version that worked for me. The second example seems to ignore the offset even with the parseInt.

   module.exports = function (app) {
       app.get("/comment", function (req, res) {
           req.db.models.Comment.find().limit(parseInt(req.query.limit)).offset(parseInt(req.query.offset)).run(function (err, results) {
               console.log(err);
               var response = {
                   results : [],
                   success : false
               };
               response.total = results.length;
               response.results = results;
               res.send(response);
           });
       });
7. dresende

   added a commit that references this issue on Mar 28, 2013

   Avoids loosing previously set limit (if set) on Model.fin() (#93)

   6beae85
8. dresende commented on Mar 28, 2013

   

   dresende

   on Mar 28, 2013

   Owner

   More actions

   I found the issue, it was because when doing { offset: ... } it was replacing the options and so the previously set limit was discarded. If you switch the order of the arguments it wouldn't happen. Anyway, I did a small fix.