Repository navigation
beforeCreate and Model Properties #69
Description
Hi,
Thanks a lot for this project. I was wondering if I'm doing something wrong here—I expect to be able to modify the properties of a model in beforeCreate, but Postgres shows the following in the database:
id | email | password | salt | created
----+---------------------+----------+------+---------
1 | test@email.com | visible? | |
var orm = require('orm'),
bcrypt = require('bcrypt');
orm.connect('postgres://localhost/database', function (err, db) {
var Person = db.define('Person', {
email: String,
password: String,
salt: String,
created: Date
}, {
validations: {
email: orm.validators.unique()
},
hooks: {
beforeCreate: function () {
if (!this.salt) {
console.log('Generating salt...');
this.salt = bcrypt.genSaltSync(10);
this.created = new Date();
}
if (this.password) {
console.log('Hashing password...');
this.password = bcrypt.hashSync(this.password, this.salt);
}
}
}
});
// Person.sync(function (err) { console.log(err); });
Person.create([{
email: 'test@email.com',
password: 'visible?'
}], function (err, items) {
console.log(err);
// console.log(items);
});
});Testing with beforeSave yields different results for me, too: the password gets hashed, but salt and created go unset in the database.
Activity
markandrus commentedon Mar 9, 2013
After looking at
/lib/Instance.js, I guess the functionality I'm looking for requires threadingdataas an argument through the hook.dresende commentedon Mar 9, 2013
Actually, the blame is
beforeCreateshould be right after/beforebeforeSave(a few lines above). In that zone, you can use thethiscontext to change the data. I'm going to make this change.Moves beforeCreate to near beforeSave so people change change instanc…
dresende commentedon Mar 9, 2013
If you want to test it you have to check the latest git version, it will take some days before pushing a new version. Or you can use the hook
beforeSavewhich should have the same behavior for new instances (but you'll also have it trigger for not new instances).markandrus commentedon Mar 9, 2013
Thanks! I've tested and it works when updating properties enumerated in the call to
create, but I can't add properties—for example, to get the above to populate the salt column, I have to change thecreatecall to include that key:Fixes bug when creating Models without all data (#69)
dresende commentedon Mar 11, 2013
Please try it now.
dxg commentedon Mar 13, 2013
This works however rangeLength validator is checking for
undefined, whereas attributes not listed inPerson.create[{...}]are now initialised tonulland the validation blows up.Is it possible for an attribute to ever be undefined? Should the validation only be checking for null, or both null & undefined?
dresende commentedon Mar 13, 2013
You're right. To be consistent, it should initialize to undefined.
Changes undefined instance properties initialization to undefined ins…
Fixes bug where beforeCreate hook is always called regardless if the …
dresende commentedon Mar 13, 2013
I'm going to assume it's fixed. If you have any other problems please reopen or create a new issue :)
markandrus commentedon Mar 14, 2013
Just tested--it works! Thanks
Merge pull request #77 from markandrus/master