Skip to content

beforeRemove not triggered #471

Open
Open
beforeRemove not triggered#471
Labels
bugenhancement
Milestone
2.1.x

Description

@FilipLukac
FilipLukac
opened on Mar 13, 2014

Hello, I have this code.

model.find({id:id}).remove(function(err){ db.close(); _this.sendAllRequestsToClient(); });
Everything is ok, removing works excelent. But hook beforeRemove is not triggered. Could anyone tell me if am I doing something wrong? thanks

beforeRemove: function(next){ var _this = this; console.log('beforeRemove ok OK OK OK OK OK OK OK '); this.getTaxi(function(err,taxi){ console.log('taxi sa nasiel akopan'); taxi.reserved=0; taxi.save(); next(); }); }

Activity

  1. dxg
    added this to the milestone on Mar 13, 2014

  2. dxg commented on Mar 13, 2014

    @dxg
    dxg
    on Mar 13, 2014
    Collaborator

    The chained remove operates on a list of items rather than individual ones.
    Because of this, it does a batch deletion rather than instantiating every single item - and without instantiating, it can't run hooks.

    I want to fix this in 2.1.5.
    The idea is to have something like:

    .find().remove(function (err) {...}) // remove hooks fired
.find().remove(fireHooks: false, function (err) {...}) // remove hooks not fired

    so that people can either get the default expected behaviour or the non hook running fast behaviour.

  3. dxg
    added
    enhancement
    on Mar 13, 2014

  4. FilipLukac commented on Mar 13, 2014

    @FilipLukac
    FilipLukac
    on Mar 13, 2014
    Author

    I want to delete by PK, but I dont know how and I didn't found it. I tried to model.get(id).remove(); and this didn't go well, server crashed

  5. dxg commented on Mar 14, 2014

    @dxg
    dxg
    on Mar 14, 2014
    Collaborator

    .get isn't chainable at the moment; only find and a few others are.
    To delete just one item, you can:

    model.get(id, function (err, item) {
  item.remove(function (err) {
    // item removed
  });
});

  6. FilipLukac commented on Mar 15, 2014

    @FilipLukac
    FilipLukac
    on Mar 15, 2014
    Author

    again.. Thanks !

  7. bvallelunga commented on Mar 24, 2014

    @bvallelunga
    bvallelunga
    on Mar 24, 2014

    @dxg has any progress been made on this issue?

  8. dxg commented on Mar 24, 2014

    @dxg
    dxg
    on Mar 24, 2014
    Collaborator

    Not yet. First I need to sort out #375 then I'll get onto this one.

  9. jacobp100 commented on Nov 4, 2014

    @jacobp100
    jacobp100
    on Nov 4, 2014

    Maybe we could check if the model has remove callbacks as well as the optional 'don't fire remove hooks'.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugenhancement

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions