Skip to content

change con.end() to con.release() for pooled mysql connections #335

Closed

Description

@snej51

There are changes made to the actual mysql driver when using pooled connections:

mysqljs/mysql#537

Perhaps it is necessary to change con.end() to con.release() because of this warning:

Calling conn.end() to release a pooled connection is deprecated. In next version calling conn.end() will be restored to default conn.end() behavior. Use conn.release() instead.

thx Jens

Activity

  1. dresende commented on Sep 13, 2013

    @dresende
    Owner

    Thank you for reminding this. It's not released just yet, but I'm making a change to check if release is defined and use it instead. Otherwise it will continue to call end.

  2. snej51 commented on Sep 14, 2013

    @snej51
    Author

    Thank you!

  3. dresende commented on Sep 15, 2013

    @dresende
    Owner

    mysql@2.0.0-alpha9 seems to have the con.release but I'll keep the code for a while so people can update orm without having to update mysql.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions