Repository navigation
Add findByAssociation to extendsTo #314
Description
I would like to suggest adding the findByAssociation method to models that are extended using extendsTo just like the one the hasOne association provides.
var User = db.define({
username: String
});
var Account = User.extendsTo({
facebookId: String
}, {
table: 'account'
} );
// This would be nice:
User.findByAccount({
facebookId: '123456789'
}, function (err, user) {
// user
});I don't quite understand, why this is possible though:
Account.findByUser({
username: 'dude'
}, function (err, account) {
// account
});
Activity
dresende commentedon Aug 26, 2013
The second option is possible because in the background an
extendsTois ahasOnein the opposite direction and with some sugar. I'll see if I have time now to add thefindBy*and add some tests for it.ptnplanet commentedon Aug 26, 2013
Ah, yes. Now I see it. With
extendsToa hasOne association is created in the opposite direction - the extended table gets the foreign id and uses it as its primary key. Creating a hasOne in the other direction would put the foreign id in the base table and the extended table would need a primary key on its own.The method for creating
findBy*would then need to be shared by hasOne and by extendsTo.Adds findByAssociation to extendsTo (#314)
ptnplanet commentedon Sep 23, 2013
Thanks!