Error Codes #206

Activity

1. dresende commented on Jun 22, 2013

   

   dresende

   on Jun 22, 2013

   Owner

   More actions

   Can you show me an example of such error?
2. jogly commented on Jun 23, 2013

   

   jogly

   on Jun 23, 2013

   CollaboratorAuthor

   More actions

   Gladly :)

   For example, the Model function get(id, callback) can throw a few errors, some of which are, missing callback; key length mismatches; or, my allowable error, a not found error. The only identifiable information available is the "Not found" string in the error object. One solution is to extend the error object into a generic ORM error object that will contain the message and a code.

   var ORMError = function(msg, code[, constr]) {
       Error.captureStackTrace(this, constr || ORMError);
       this.message = msg;
       this.code = code;
   };
   
   util.inherits(ORMError, Error);

   Now, we can use throw new ORMError("Same message", NEW_CODE);, or create reusable errors:

   var NotFoundError = function(msg) {
       this.super_.call(this, msg, SOME_CODE, this.constructor);
   };
   
   util.inherits(NotFoundError, ORMError);

   This is something that could be phased in without affecting any existing code since every custom error will already effectively be an error.
3. dresende commented on Jun 24, 2013

   

   dresende

   on Jun 24, 2013

   Owner

   More actions

   Ok, I clearly see your point. You would like to have a way of distinguishing the errors without parsing a string (that might change). We have to identify them and create codes for them, perhaps having a global orm file with the list of codes (that people can lookup) and orm will use. I have to create a basic one, perhaps starting with the Model.get.
4. dresende

   added a commit that references this issue on Jun 27, 2013

   Changes many errors to use the ErrorCodes generator (#206)

   c94866f
5. dresende commented on Jun 27, 2013

   

   dresende

   on Jun 27, 2013

   Owner

   More actions

   There should be more missing errors there, I have to change all of them. If you find any, feel free to change it.
6. dresende

   added a commit that references this issue on Jun 27, 2013

   Changes more errors to use the new ErrorCodes generator (#206)

   3313e36
7. dresende commented on Jun 27, 2013

   

   dresende

   on Jun 27, 2013

   Owner

   More actions

   I think I added most of them. If you find any please reopen.
8. dresende

   closed this as completedon Jun 27, 2013