findOne convenience function #148

Activity

1. dresende commented on May 5, 2013

   

   dresende

   on May 5, 2013

   Owner

   More actions

   There is a Model.all so probably I'll create a Model.one. In your case it shouldn't be possible because you should have at most 1 result or your authentication might have a breach :) I'll commit it soon and release it this week.
2. dresende

   added a commit that references this issue on May 5, 2013

   Adds Model.one() as an alias for Model.all().limit(1) (#148)

   1c9e1ba
3. dresende

   closed this as completedon May 5, 2013
4. jogly commented on May 6, 2013

   

   jogly

   on May 6, 2013

   CollaboratorAuthor

   More actions

   Haha, yes, having more than one result would be indicative of an issue. More along the lines of what I hoped to solve with this idea is eliminating the var user = users[0] from the following snippet:

   User.find({ username: username }, function (err, users) {
     var user = users[0];
     ...

   with

   // findOne or one, syntax is obviously up to you. 
   // I'm familiar with the findOne vs. find from the Mongoose API.
   User.[findOne | one]({ username: username }, function (err, user) {
     // no need to access the first element.
     ...

   Will the alias Model.one() cover this concept? From my understanding (which may very well be incorrect), even if it is a limit of 1 it will still return an array, albeit with a length of 1.
5. dxg commented on May 6, 2013

   

   dxg

   on May 6, 2013

   Collaborator

   More actions

   Could also call it 'first()'.
   i too would find it useful if it just returned the item rather than an array.
6. dresende commented on May 6, 2013

   

   dresende

   on May 6, 2013

   Owner

   More actions

   Yes, the simple implementation I added will return an Array of results. I'll have to change it.
7. dresende

   reopened this on May 6, 2013
8. dresende

   added a commit that references this issue on May 6, 2013

   Changes Model.one() to return only one instance (or null) instead of …

   ...

   ba74d85
9. dresende commented on May 6, 2013

   

   dresende

   on May 6, 2013

   Owner

   More actions

   For now it forces a callback, you can't do this:

   Model.one(....).run(function (...) {
   });

   For now, only:

   Model.one(...., function (...) {
   });
10. dresende

    closed this as completedon May 6, 2013