Repository navigation
Conversation
Since commit 0d3e86d ("chore(cmake): use zlib from libs"), the zlib CMake module comes from the falcosecurity libs, whose CMake modules are only added to CMAKE_MODULE_PATH when building the bundled falcosecurity libs. So, when linking to the shared falcosecurity libs (USE_BUNDLED_FALCOSECURITY_LIBS=OFF), including the zlib module fails: include could not find requested file: zlib sysdig doesn't use zlib directly, the module is only needed to build the bundled falcosecurity libs, so only include it in that case. Signed-off-by: Angelo Compagnucci <angelo.compagnucci@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since commit 0d3e86d ("chore(cmake): use zlib from libs"), the zlib CMake module comes from the falcosecurity libs, whose CMake modules are only added to CMAKE_MODULE_PATH when building the bundled falcosecurity libs. So, when linking to the shared falcosecurity libs (USE_BUNDLED_FALCOSECURITY_LIBS=OFF), including the zlib module fails:
include could not find requested file:
sysdig doesn't use zlib directly, the module is only needed to build the bundled falcosecurity libs, so only include it in that case.